@W-21200034: Add scaffolding to override some config entries at runtime #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyoung-tableau
commented
Feb 9, 2026
anyoung-tableau
changed the title
anyoung-tableau
changed the title
anyoung-tableau
changed the title
anyoung-tableau
commented
Feb 11, 2026
anyoung-tableau
commented
Feb 11, 2026
anyoung-tableau
commented
Feb 11, 2026
anyoung-tableau
commented
Feb 11, 2026
anyoung-tableau
commented
Feb 11, 2026
anyoung-tableau
commented
Feb 11, 2026
anyoung-tableau
commented
Feb 11, 2026
anyoung-tableau
commented
Feb 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds infrastructure for runtime configuration overrides via MCP site settings, preparing for a future REST API that will allow server-side configuration management. The changes introduce an OverridableConfig class that separates runtime-overridable settings from static Config settings, implements caching for MCP site settings with configurable TTL, and updates all tool methods to use the override mechanism.
Changes:
- Extracted overridable configuration logic from
Configinto a newOverridableConfigclass that supports runtime overrides - Added caching infrastructure using
ExpiringMapto minimize API calls when fetching MCP site settings (placeholder implementation returns empty settings until REST API is available) - Updated
RestApiArgstype to support optional logging via discriminated union, enabling config fetching during server initialization - Modified all tool methods to call
getConfigWithOverrides()and use the overridable bounded context and limits
Reviewed changes
Copilot reviewed 33 out of 35 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| types/process-env.d.ts | Added environment variables for MCP site settings feature flag and cache interval |
| src/utils/types.ts | Added DistributiveOmit utility type for properly handling discriminated unions |
| src/utils/mcpSiteSettings.ts | Core logic for fetching, caching, and applying MCP site settings overrides |
| src/utils/mcpSiteSettings.test.ts | Tests for MCP site settings functionality including caching behavior |
| src/overridableConfig.ts | New class containing all runtime-overridable configuration logic extracted from Config |
| src/overridableConfig.test.ts | Comprehensive tests for OverridableConfig class |
| src/sdks/tableau/types/mcpSiteSettings.ts | Type definition for MCP site settings as string-to-string map |
| src/sdks/tableau/restApi.ts | Added placeholder siteMethods.getMcpSettings() that returns empty settings |
| src/config.ts | Removed overridable settings; added new MCP site settings configuration properties |
| src/config.test.ts | Updated tests after extracting overridable config logic |
| src/restApiInstance.ts | Refactored to use RestApiArgs type with discriminated union for optional logging |
| src/server.ts | Made _getToolsToRegister async to support fetching config with overrides |
| src/tools/resourceAccessChecker.ts | Updated to use async getter methods that fetch overridable config |
| src/tools/workbooks/listWorkbooks.ts | Updated to fetch and use config with overrides |
| src/tools/workbooks/getWorkbook.ts | Updated to fetch and use config with overrides |
| src/tools/views/listViews.ts | Updated to fetch and use config with overrides |
| src/tools/views/getViewImage.ts | Updated to construct restApiArgs consistently |
| src/tools/views/getViewData.ts | Updated to construct restApiArgs consistently |
| src/tools/queryDatasource/queryDatasource.ts | Updated to fetch and use config with overrides |
| src/tools/pulse/*.ts | Updated all Pulse tools to fetch and use config with overrides |
| src/tools/listDatasources/listDatasources.ts | Updated to fetch and use config with overrides |
| src/tools/getDatasourceMetadata/getDatasourceMetadata.ts | Updated to fetch and use config with overrides |
| src/tools/contentExploration/searchContent.ts | Updated to fetch and use config with overrides |
| src/tools/contentExploration/searchContentUtils.ts | Updated BoundedContext import |
| src/tools/pulse/constrainPulseMetrics.ts | Updated BoundedContext import |
| src/tools/pulse/constrainPulseDefinitions.ts | Updated BoundedContext import |
| src/scripts/createClaudeMcpBundleManifest.ts | Added new environment variables to manifest |
| package.json | Version bump to 1.14.7 |
| package-lock.json | Version bump to 1.14.7 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/tools/pulse/listMetricsFromMetricIds/listPulseMetricsFromMetricIds.ts
Show resolved
Hide resolved
src/tools/pulse/listMetricsFromMetricDefinitionId/listPulseMetricsFromMetricDefinitionId.ts
Show resolved
Hide resolved
.../pulse/listMetricDefinitionsFromDefinitionIds/listPulseMetricDefinitionsFromDefinitionIds.ts
Show resolved
Hide resolved
jarhun88
reviewed
Feb 11, 2026
jarhun88
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes lay the groundwork for @W-21200059: Add Get/Update MCP site settings REST APIs.
Once the "Get MCP Site Settings" REST API is available, we can call it to get the actual site settings. Currently, the
ENABLE_MCP_SITE_SETTINGSfeature is disabled but can be enabled for testing. When enabled, the method that retrieves the MCP site settings returns a placeholder empty object (implying no overrides).